-
Notifications
You must be signed in to change notification settings - Fork 3
Add Weekly Update Household API feature #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
anth-volk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @hua7450. One recommendation: I'd write that large bash block as one or more scripts, then invoke in the GH Action. I'd also recommend a few unit tests for said scripts.
anth-volk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hua7450!
Summary
Adds a GitHub Actions workflow for automated weekly updates of
policyengine-uspackage.Fixes #1178
Features
workflow_dispatchpolicyengine-usversionHow It Works
setup.pysetup.pywith new versionchangelog.yamlfrom policyengine-us repochangelog_entry.yamlFiles Changed
.github/workflows/weekly-update.yaml- Workflow file (invokes scripts).github/scripts/check_updates.py- Python script for checking updates and generating summary.github/scripts/create_pr.sh- Bash script for creating/updating PRs.github/scripts/test_check_updates.py- Unit tests for the Python script (20 tests)Code Review Changes
Based on reviewer feedback, refactored the workflow:
.github/scripts/check_updates.py.github/scripts/create_pr.sh.github/scripts/test_check_updates.pycovering:Test Plan
pushtrigger andrefoverride)